fix(grit): equivalence tests + minor fixes #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
changed the title
github-actions
bot
added
A-Parser
CodSpeed Performance ReportMerging #3595 will improve performances by 7.19%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Grit bindings to fix another edge case. Previously,
$fn && fn()would matchfoo && foo(), but notfoo.bar && foo.bar(). This fixes the parser so we don't "overfit" towards identifiers.While debugging I ran into a fun issue, which is that there are two Unicode "mu" characters, uppercase µ (Unicode 181) and lowercase μ (Unicode 956). They're hardly distinguishable (and some monospace fonts don't seem to make any distinction), but 181 (upper case) is the correct one we should use. cc @ah-yu
With these fixes out of the way, I ran into another
todo!()regarding equivalence tests, which have now been ported from Grit as well. And lo and behold,foo.bar && foo.bar()now matches too :)Test Plan
Test added.